feat: add cli commands to create/set/unset/edit sources for multi-source application #17425

ishitasequeira · 2024-03-06T15:39:35Z

The PR focusses on 4 commands:

argocd app create - The current app create command works with file option for creating multi-source apps but overrides parameters only for 1st source while specifying additional options. The PR allows users to provide source index for overriding parameters for a specific source.

Example command:

$ ./dist/argocd app create --file ~/app1.yaml --repo https://github.com/ishitasequeira/argocd-example-apps.git --source-index 1
application 'guestbook' created

argocd app set - The current app set command does not allow to set and override parameters for a multi-source application. The PR updates the command to be able to set overrides for a specific source index.

Example command:

$ ./dist/argocd app set guestbook --source-index 1 --ref values --repo https://github.com/ishitasequeira/argocd-example-apps.git

argocd app unset - The current app unset command does not allow to set and override parameters for a multi-source application. The PR updates the command to be able to unset overrides for a specific source index.

Example command:

$ ./dist/argocd app unset guestbook --source-index 1 --namesuffix

argocd app edit - The current app edit command does not allow to override parameters for a multi-source application while editing the application. The PR updates the command to be able to edit overrides for a specific source index.

Example command:

$ ./dist/argocd app edit guestbook --source-index 1 --repo https://github.com/ishitasequeira/argocd-example-apps.git

Checklist:

jannfis

I think from a UX perspective (principle of least surprise), it would make sense that when an app has multiple sources defined and --source-index is not specified, that the request will fail.

E.g.

./dist/argocd app create --file ~/app1.yaml --repo https://github.com/ishitasequeira/argocd-example-apps.git

will fail instead of assuming the default source index to be 0.

This might prevent the one or other accident.

ishitasequeira · 2024-03-08T16:43:25Z

That does make sense.

I defaulted it to 0 for maintaining today's behavior. I will update it to error out.

codecov · 2024-03-08T19:39:32Z

Codecov Report

Attention: Patch coverage is 16.49485% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 49.39%. Comparing base (05eea87) to head (8ef0fc9).
Report is 30 commits behind head on master.

❗ Current head 8ef0fc9 differs from pull request most recent head 3520132. Consider uploading reports for the commit 3520132 to get more accurate results

Files	Patch %	Lines
cmd/argocd/commands/app.go	8.69%	62 Missing and 1 partial ⚠️
cmd/util/app.go	43.47%	12 Missing and 1 partial ⚠️
pkg/apis/application/v1alpha1/types.go	0.00%	4 Missing ⚠️
cmd/argocd/commands/admin/app.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #17425      +/-   ##
==========================================
- Coverage   49.44%   49.39%   -0.05%     
==========================================
  Files         273      273              
  Lines       48662    48735      +73     
==========================================
+ Hits        24063    24075      +12     
- Misses      22237    22297      +60     
- Partials     2362     2363       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira · 2024-03-11T13:15:49Z

@jannfis I have updated the code for commands edit, set and unset to error out when source_index is not provided for multi-source apps.
Although, it is a bit difficult to do the same for create command. The current flow of create command when specifying --file option, by default calls SetAppSpecOptions to iterate over all flags/appOptions to set the default values if any flag is specified. I could not find a way to find the length of flags specified to see if any flag other than source_index was set.

Thus, left the create command with source_index defaulting to 0.

jannfis · 2024-03-11T14:42:20Z

Thus, left the create command with source_index defaulting to 0.

I was wondering if it makes sense to support manipulating the source for the create command at all, or if the create command should abort if the app a) has multiple sources and b) is templated from a YAML and c) one of the source modificators, such as --repo, is specified.

AFAIU (keep me honest here), it would only be possible for the create command to override a single source definition for a given app (as specified by --source-index), but not modify multiple app sources. As opposed to edit or set, create cannot be called multiple times using a different --source-index for the same application.

I haven't looked yet, but is the app create command able to generate a multi-source application without a YAML template right now?

ishitasequeira · 2024-03-11T16:45:37Z

Thus, left the create command with source_index defaulting to 0.

I was wondering if it makes sense to support manipulating the source for the create command at all, or if the create command should abort if the app a) has multiple sources and b) is templated from a YAML and c) one of the source modificators, such as --repo, is specified.

I had the same question initially and I am still open to stop allowing to override parameters. I kept it to update for allowing the behavior supported today.

AFAIU (keep me honest here), it would only be possible for the create command to override a single source definition for a given app (as specified by --source-index), but not modify multiple app sources. As opposed to edit or set, create cannot be called multiple times using a different --source-index for the same application.

Yes, the user will be able to override the definition only for a single source specified by source-index.

I haven't looked yet, but is the app create command able to generate a multi-source application without a YAML template right now?

Yes, the multi-source application can be created only with YAML configuration (that is with fileURL specified).

jannfis · 2024-03-11T17:42:08Z

I'm not sure if this is possible with cobra, but do you think we can have dynamic command line arguments? Then instead of --repo <url> --source-index X, we could have --repoX (where X specifies the index of the source), so

--repo foo --source-index 0

would become

--repo0 foo

We'd be able to override all repository URLs atomically within a single command execution, for both create and edit.

For this, we wouldn't define the parameters statically but see at runtime whether that flag would be valid (e.g. --repo127 obviously wouldn't be valid if the application only has 125 sources).

Not sure if that's cool or even worth the hassle, though.

ishitasequeira · 2024-03-11T19:40:00Z

I recall not opting for implementing dynamic flags while developing the ApplicationSet CLI. This decision was mainly driven by concerns about having huge list of command arguments (in this case it would be for defining multiple sources). Also, it would be difficult to validate the application source definition for missing properties.

I think it would be good to begin with not allowing overrides. We can see if there is any ask for overrides from the community and come to a consensus around it's implementation. WDYT?

jannfis · 2024-03-11T20:10:08Z

Yep, I'm cool with that!

ishitasequeira · 2024-03-12T01:05:32Z

@jannfis I have updated the PR.

jannfis

First round, mostly nits and style concerns.

jannfis · 2024-03-12T13:29:08Z

cmd/argocd/commands/app.go

@@ -730,6 +732,7 @@ func NewApplicationSetCommand(clientOpts *argocdclient.ClientOptions) *cobra.Com
 	var (
 		appOpts      cmdutil.AppOptions
 		appNamespace string
+		source_index int


Just a nit, but this should be sourceIndex instead of source_index (also, throughout all other files, too)

jannfis · 2024-03-12T13:31:07Z

cmd/argocd/commands/app.go

@@ -747,6 +750,9 @@ func NewApplicationSetCommand(clientOpts *argocdclient.ClientOptions) *cobra.Com
  # Set and override application parameters with a parameter file
  argocd app set my-app --parameter-file path/to/parameter-file.yaml

+  # Set and override application parameters for a source at index 1 under spec.sources of app my-app (Indexes start at 0)


I was wondering if it would confusing be for the majority of users that the index starts at 0. For programmers, it might feel natural to start counting at 0, but the majority of people probably start counting at 1 🙂

Updated it to start counting at 1 😅

jannfis · 2024-03-12T13:32:15Z

cmd/argocd/commands/app.go

@@ -825,9 +845,12 @@ func NewApplicationUnsetCommand(clientOpts *argocdclient.ClientOptions) *cobra.C
 		Example: `  # Unset kustomize override kustomize image
  argocd app unset my-app --kustomize-image=alpine

-  # Unset kustomize override prefix
+  # Unset kustomize override suffix


jannfis · 2024-03-12T13:33:12Z

cmd/argocd/commands/app.go

 	return command
 }

 func unset(source *argoappv1.ApplicationSource, opts unsetOpts) (updated bool, nothingToUnset bool) {
+


Suggested change

jannfis · 2024-03-12T13:35:36Z

cmd/argocd/commands/app.go

 	if source.Kustomize != nil {
 		if opts.KustomizeIsZero() {
-			return false, true
+			return updated, !needToUnsetRef && true


!needToUnsetRef && true somehow reads (and possibly is) redundant

jannfis · 2024-03-12T13:36:43Z

cmd/argocd/commands/app.go

@@ -981,7 +1025,7 @@ func unset(source *argoappv1.ApplicationSource, opts unsetOpts) (updated bool, n
 			}
 		}
 	}
-	return updated, false
+	return updated, !needToUnsetRef && false


Another one :)

cmd/argocd/commands/app.go

cmd/util/app.go

jannfis · 2024-03-12T13:42:35Z

cmd/argocd/commands/app.go

+  # Create a MultiSource app
+  argocd app create guestbook --file <path-to-yaml-file>
+


Reading this, I will assume that just by pointing to a YAML would give me a multi source app, but I think this is not true.

It is true given that the yaml file contains application configured with multiple sources. I will specify that in the example.

e.g.:

$ ./dist/argocd app create --file ~/app1.yaml application 'guestbook' created

ishitasequeira · 2024-03-12T20:15:28Z

@jannfis Addressed all your comments.

cmd/util/app_test.go

…rce app" Signed-off-by: ishitasequeira <[email protected]>

Signed-off-by: ishitasequeira <[email protected]>

anandf

LGTM

jannfis

LGTM, thanks @ishitasequeira !

…rce application (argoproj#17425) * "feat:add cli commands to create/set/unset/edit sources for multi-source app" Signed-off-by: ishitasequeira <[email protected]> * fixed the ci failure Signed-off-by: ishitasequeira <[email protected]> * update commands Signed-off-by: ishitasequeira <[email protected]> * error out if source-index not specified for multi-source applications Signed-off-by: ishitasequeira <[email protected]> * fixed the ci failure Signed-off-by: ishitasequeira <[email protected]> * fix tests Signed-off-by: ishitasequeira <[email protected]> * set 0 as default source index for app create Signed-off-by: ishitasequeira <[email protected]> * add index to ParameterOverrides function Signed-off-by: ishitasequeira <[email protected]> * do not allow overrides for applications with multiple sources Signed-off-by: ishitasequeira <[email protected]> * update tests Signed-off-by: ishitasequeira <[email protected]> * remove create with override example Signed-off-by: ishitasequeira <[email protected]> * address comments Signed-off-by: ishitasequeira <[email protected]> * update tests Signed-off-by: ishitasequeira <[email protected]> * update examples in docs Signed-off-by: ishitasequeira <[email protected]> * update logs Signed-off-by: ishitasequeira <[email protected]> * Add test and update docs Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>

…rce application (argoproj#17425) * "feat:add cli commands to create/set/unset/edit sources for multi-source app" Signed-off-by: ishitasequeira <[email protected]> * fixed the ci failure Signed-off-by: ishitasequeira <[email protected]> * update commands Signed-off-by: ishitasequeira <[email protected]> * error out if source-index not specified for multi-source applications Signed-off-by: ishitasequeira <[email protected]> * fixed the ci failure Signed-off-by: ishitasequeira <[email protected]> * fix tests Signed-off-by: ishitasequeira <[email protected]> * set 0 as default source index for app create Signed-off-by: ishitasequeira <[email protected]> * add index to ParameterOverrides function Signed-off-by: ishitasequeira <[email protected]> * do not allow overrides for applications with multiple sources Signed-off-by: ishitasequeira <[email protected]> * update tests Signed-off-by: ishitasequeira <[email protected]> * remove create with override example Signed-off-by: ishitasequeira <[email protected]> * address comments Signed-off-by: ishitasequeira <[email protected]> * update tests Signed-off-by: ishitasequeira <[email protected]> * update examples in docs Signed-off-by: ishitasequeira <[email protected]> * update logs Signed-off-by: ishitasequeira <[email protected]> * Add test and update docs Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]>

* docs(webhook): use real cm name instead of placeholder (#17002) The document says I should registed configMap named argocd-notifications-cm but then uses placeholder in examples. Signed-off-by: Petr Studeny <[email protected]> * docs: Update Okta OIDC SSO docs (#13811) * Update the Okta SSO docs * fill out the OIDC section with step-by-step instructions on using Okta with custom authorization servers * adjust outdated docs about updating the docs Signed-off-by: Jonas Courteau <[email protected]> * Add the Okta version that these docs are written against Signed-off-by: Jonas Courteau <[email protected]> --------- Signed-off-by: Jonas Courteau <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * Add a description for using contour httpproxy CRD (#14614) Which allows you to reuse the same hostname. Co-authored-by: Boris Smidt <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * fix: ci failures (#17107) Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * chore(deps): bump library/golang from 1.21.3 to 1.22.0 in /test/remote (#17111) Bumps library/golang from 1.21.3 to 1.22.0. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump yarn from 1.22.10 to 1.22.13 in /ui-test (#17092) Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.22.10 to 1.22.13. - [Release notes](https://github.com/yarnpkg/yarn/releases) - [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md) - [Commits](https://github.com/yarnpkg/yarn/compare/1.22.10...v1.22.13) --- updated-dependencies: - dependency-name: yarn dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/redis from 7.0.11 to 7.2.4 in /test/container (#16806) Bumps library/redis from 7.0.11 to 7.2.4. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps-dev): bump yarn from 1.22.10 to 1.22.21 in /ui (#17096) Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.22.10 to 1.22.21. - [Release notes](https://github.com/yarnpkg/yarn/releases) - [Changelog](https://github.com/yarnpkg/yarn/blob/master/CHANGELOG.md) - [Commits](https://github.com/yarnpkg/yarn/compare/1.22.10...v1.22.21) --- updated-dependencies: - dependency-name: yarn dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * fix the typo (#17116) * chore(deps): bump library/node from 20.6.1 to 21.6.1 (#17053) Bumps library/node from 20.6.1 to 21.6.1. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/node from 20.7.0 to 21.6.1 (#17065) Signed-off-by: fengshunli <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * fix(kustomize): set build dir (#15057) #16229 #16652 (#16653) * use repo root, not app path Signed-off-by: Prune <[email protected]> correct patch Signed-off-by: Prune <[email protected]> * use Getwd to find the root path for diff commands Signed-off-by: Prune <[email protected]> * set dot a default for argo app commands Signed-off-by: Prune <[email protected]> * revert default values Signed-off-by: Prune <[email protected]> * patch diff in TestNamespacedResourceDiffing Signed-off-by: Prune <[email protected]> * patching some diff and sync Signed-off-by: Prune <[email protected]> * patch remaining diff in error Signed-off-by: Prune <[email protected]> --------- Signed-off-by: Prune <[email protected]> * chore(ci): tweak backend filters (#17134) The existing backend filters get triggered even on frontend-only or docs-only changes, which should not be the case. The reason for this seems to be the fact that each filter line is ORed rather than ANDed. To remedy this, we put all the filters on the same line. I tried the filter out in a REPL (https://runkit.com/blakepettersson/65c3daba99653f0008c74eda). This is a filter using picomatch (the same library `dorny/paths-filter` uses). Signed-off-by: Blake Pettersson <[email protected]> * docs: fix error in toolchain setup (#17154) Signed-off-by: Alexandre Gaudreault <[email protected]> * chore(dex): 2.37.0 to 2.38.0 (#17157) Signed-off-by: asingh51 <[email protected]> Co-authored-by: asingh51 <[email protected]> * feat: Add support for passing Redis Sentinel username(ACL) and password (#17168) * Add support for passing Sentinel username and password Signed-off-by: ShlomiTubul <[email protected]> * fix align with var naming Signed-off-by: ShlomiTubul <[email protected]> * fix align with var naming Signed-off-by: ShlomiTubul <[email protected]> --------- Signed-off-by: ShlomiTubul <[email protected]> Co-authored-by: ShlomiTubul <[email protected]> * fix: stop initializing deployment informer if dynamic sharding is disabled (#17097) * fix: stop initializing deployment informer if dynamic sharding is disabled Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: updated sharding cache getter func Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: query escape function for notifications (#16343) Signed-off-by: Jan Schumann <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * Update triggers doc to fix typo (#17185) Signed-off-by: David Grizzanti <[email protected]> * docs: fixes Template.md targetRevision typo (#17190) * Template.md targetRevision typo fixed Signed-off-by: Ajay Chidambaram <[email protected]> * retrigger checks Signed-off-by: Ajay Chidambaram <[email protected]> * sign off Signed-off-by: chidambaram27 <[email protected]> Signed-off-by: Ajay Chidambaram <[email protected]> * sign off Signed-off-by: Ajay Chidambaram <[email protected]> --------- Signed-off-by: Ajay Chidambaram <[email protected]> Signed-off-by: chidambaram27 <[email protected]> * docs: Private-helm-repo section target added to helm.md (#16697) * helm-repo Signed-off-by: Surajyadav <[email protected]> * Update docs/user-guide/helm.md Co-authored-by: Blake Pettersson <[email protected]> Signed-off-by: Suraj yadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Suraj yadav <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> * fix: infer correct shard in statefulset setup (#17124, #17016) (#17167) * fix: infer correct shard in statefulset setup Signed-off-by: Lukas Wöhrl <[email protected]> * fix the case if only a single replica Signed-off-by: Lukas Wöhrl <[email protected]> * fix: resolving pointer on shard compare Signed-off-by: Lukas Wöhrl <[email protected]> * fix: add readlock for cluster accessor Signed-off-by: Lukas Wöhrl <[email protected]> * fix: use defer to protect access of 'shard' Signed-off-by: Lukas Wöhrl <[email protected]> * fix: revert locking in getclusteraccessor Signed-off-by: Lukas Wöhrl <[email protected]> * fix: handle nil shard case Signed-off-by: Lukas Wöhrl <[email protected]> * fix: handle any nil shard value as false Signed-off-by: Lukas Wöhrl <[email protected]> * fix: handle nil case and fix another missing pointer dereference Signed-off-by: Lukas Wöhrl <[email protected]> * revert Signed-off-by: Lukas Wöhrl <[email protected]> * fix: added tests and fixed some behaviour bugs Signed-off-by: Lukas Wöhrl <[email protected]> * test: add test to validate that Shard value is not overriden Signed-off-by: Lukas Wöhrl <[email protected]> * fix: added tests and fixe the case when server is changed inside a secret Signed-off-by: Lukas Wöhrl <[email protected]> * tests: add test cases for infering the shard logic Signed-off-by: Lukas Wöhrl <[email protected]> --------- Signed-off-by: Lukas Wöhrl <[email protected]> * feat: wait until resources are deleted #6085 (#16733) * feat: wait until resources are deleted Signed-off-by: MichaelMorris <[email protected]> * Added unit and e2e test Signed-off-by: MichaelMorris <[email protected]> --------- Signed-off-by: MichaelMorris <[email protected]> * fix(controller): add missing workqueue metrics (#16315) (#17013) * fix(controller): add missing kubernetes metrics Signed-off-by: Alexandre Gaudreault <[email protected]> * validate workqueue metrics are present Signed-off-by: Alexandre Gaudreault <[email protected]> * use newer metrics registry Signed-off-by: Alexandre Gaudreault <[email protected]> * fix duplicated Signed-off-by: Alexandre Gaudreault <[email protected]> * init runtime controller in test to have correct metrics Signed-off-by: Alexandre Gaudreault <[email protected]> * fix lint error Signed-off-by: Alexandre Gaudreault <[email protected]> * update controller-runtime to remove metrics with high cardinality Signed-off-by: Alexandre Gaudreault <[email protected]> --------- Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Alexandre Gaudreault <[email protected]> * chore(deps): upgrade helm to 3.14.1 (#17213) * chore(deps): upgrade helm to 3.14.1 Signed-off-by: Alexandre Gaudreault <[email protected]> * move files to folder...... Signed-off-by: Alexandre Gaudreault <[email protected]> --------- Signed-off-by: Alexandre Gaudreault <[email protected]> * docs: Add PayIt to USERS.md (#17215) * docs: Add PayIt to USERS.md Signed-off-by: Matt Menzenski <[email protected]> * docs: Add PayIt to USERS.md Signed-off-by: Matt Menzenski <[email protected]> --------- Signed-off-by: Matt Menzenski <[email protected]> * docs: Add Nextbasket to USERS.md (#17228) Signed-off-by: NextBasket-Petyo <[email protected]> * fix: Permission Denied error when calling GetAppDetails API (#17221) (#17229) Signed-off-by: Keith Chong <[email protected]> * Count git checkout failures (#15657) Signed-off-by: Mikołaj Przybysz <[email protected]> Co-authored-by: Mikołaj Przybysz <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> * chore(deps): bump library/node from 21.6.1 to 21.6.2 in /ui-test (#17226) Bumps library/node from 21.6.1 to 21.6.2. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/node from 21.6.1 to 21.6.2 (#17223) Bumps library/node from 21.6.1 to 21.6.2. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/golang in /test/remote (#17138) Bumps library/golang from `094e47e` to `ef61a20`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * feat(grafana-dashboard): Update example dashboard, add AppSet Telemetry (#17232) Signed-off-by: lukepatrick <[email protected]> * chore(deps): bump library/node from `6fb1883` to `65998e3` in /ui-test (#17245) Bumps library/node from `6fb1883` to `65998e3`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/golang in /test/remote (#17244) Bumps library/golang from `ef61a20` to `7b297d9`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add `AppName` to the RepoServerAppDetailsQuery for notification-controller (#17233) Signed-off-by: Dong Wang <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/node from `50703e6` to `65998e3` (#17243) Bumps library/node from `50703e6` to `65998e3`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * docs: Update USERS.md (#17248) * Update USERS.md Signed-off-by: itayvolo <[email protected]> * Update USERS.md Signed-off-by: itayvolo <[email protected]> * Update USERS.md Signed-off-by: itayvolo <[email protected]> --------- Signed-off-by: itayvolo <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * docs(metrics): add release label to haproxy (#17264) Add missing `release` label to `argocd-redis-haproxy-metrics` ServiceMonitor example. Signed-off-by: Gaston Festari <[email protected]> * docs: Fix typo in notifications example (#17250) * Fix typo in notifications example I'm not too sure what the example should look like, so I'm taking a guess here. Signed-off-by: Adrian Moisey <[email protected]> * Update docs/operator-manual/notifications/troubleshooting.md Co-authored-by: Soumya Ghosh Dastidar <[email protected]> Signed-off-by: Adrian Moisey <[email protected]> --------- Signed-off-by: Adrian Moisey <[email protected]> Co-authored-by: Soumya Ghosh Dastidar <[email protected]> * Update contributors-quickstart.md (#17266) Signed-off-by: Dan Garfield <[email protected]> * reduce unnecessary unmarshal (#17187) Signed-off-by: Wilson Wang <[email protected]> * fix typo (#17272) Signed-off-by: Oscar Wieman <[email protected]> * docs: Added examples for alternate EKS cluster authentication methods (#17270) * Added examples for alternate EKS cluster authentication methods Signed-off-by: Damon Edstrom <[email protected]> * Update docs/operator-manual/declarative-setup.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> --------- Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * docs for PR #9791 (#16021) Signed-off-by: mzain <[email protected]> * chore(ci): use changed files action (#17180) `dorny/paths-filter` doesn't seem to handle (multiple) negations well. Therefore, this PR switches to `tj-actions/changed-files`, since it is already successfully used in argo-workflows. Signed-off-by: Blake Pettersson <[email protected]> * fix(ui): Include application name in status badge (#17126) * Added application name to badge Signed-off-by: sshenoy6 <[email protected]> * Rever svg change Signed-off-by: sshenoy6 <[email protected]> * Doc for disabling application name Signed-off-by: sshenoy6 <[email protected]> * Flag to not display application name Signed-off-by: sshenoy6 <[email protected]> * Added tests Signed-off-by: sshenoy6 <[email protected]> * Make no app name the default Signed-off-by: sshenoy6 <[email protected]> * Have enable app name as a query parameter Signed-off-by: sshenoy6 <[email protected]> * Have enable app name as a query parameter Signed-off-by: sshenoy6 <[email protected]> * argocd to original Signed-off-by: sshenoy6 <[email protected]> * Update docs/user-guide/status-badge.md Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> --------- Signed-off-by: sshenoy6 <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: sshenoy6 <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * fix: Update test image ssl/crypto libs (#17303) Signed-off-by: Carlos Santana <[email protected]> * chore(deps-dev): bump postcss from 8.2.13 to 8.4.35 in /ui (#17140) Bumps [postcss](https://github.com/postcss/postcss) from 8.2.13 to 8.4.35. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.2.13...8.4.35) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/redis in /test/container (#17137) Bumps library/redis from `cc8b0b8` to `11c3e41`. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump react-helmet and @types/react-helmet in /ui (#11556) Bumps [react-helmet](https://github.com/nfl/react-helmet) and [@types/react-helmet](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-helmet). These dependencies needed to be updated together. Updates `react-helmet` from 5.2.1 to 6.1.0 - [Release notes](https://github.com/nfl/react-helmet/releases) - [Changelog](https://github.com/nfl/react-helmet/blob/master/CHANGELOG.md) - [Commits](https://github.com/nfl/react-helmet/commits/6.1.0) Updates `@types/react-helmet` from 5.0.19 to 6.1.6 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-helmet) --- updated-dependencies: - dependency-name: react-helmet dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-helmet" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump bitnami/kubectl in /test/container (#14220) Bumps bitnami/kubectl from `670fe3f` to `14ab746`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore: add Rocket.Chat to users (#17306) Signed-off-by: Debdut Chakraborty <[email protected]> * chore(deps): bump library/ubuntu in /test/container (#13409) Bumps library/ubuntu from `9a0bdde` to `67211c1`. --- updated-dependencies: - dependency-name: library/ubuntu dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/redis in /test/container (#17309) Bumps library/redis from `11c3e41` to `e647cfe`. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/registry in /test/container (#13050) Bumps library/registry from `41f413c` to `b209a41`. --- updated-dependencies: - dependency-name: library/registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/busybox in /test/e2e/multiarch-container (#14592) Bumps library/busybox from `2376a0c` to `3fbc632`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * fix: use simple python image to build mkdocs (#17313) * fix: use simple python image to build mkdocs Signed-off-by: Carlos Santana <[email protected]> * use python 3.7 Signed-off-by: Carlos Santana <[email protected]> --------- Signed-off-by: Carlos Santana <[email protected]> * chore(deps): bump library/registry in /test/container (#17317) Bumps library/registry from `b209a41` to `f4e1b87`. --- updated-dependencies: - dependency-name: library/registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: fixed name of environment variable and config map property enabling scm providers for applicationsets (#17326) Signed-off-by: Juliusz <[email protected]> Co-authored-by: Juliusz <[email protected]> * fix(ui): Added dashed line between collapsed sections in Compact-diff (#17173) * dashed-line-breaker Signed-off-by: Surajyadav <[email protected]> * dark-mode Signed-off-by: Surajyadav <[email protected]> * dark-mode-text-fix Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> * fix: multi-source app breaks application parameters UI (#16910) (#17033) Signed-off-by: Keith Chong <[email protected]> * chore(deps): upgrade helm to 3.14.2 (#17330) * chore(deps): upgrade helm to 3.14.2 Signed-off-by: David Bunn <[email protected]> * Signing commit Signed-off-by: David Bunn <[email protected]> --------- Signed-off-by: David Bunn <[email protected]> * chore(deps): bump library/node from 21.6.1 to 21.6.2 in /test/container (#17316) Bumps library/node from 21.6.1 to 21.6.2. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * fix: The argocd server api-content-type flag does not allow empty content-type header (#17331) Signed-off-by: Alexander Matyushentsev <[email protected]> * fix(ui): The tiles in Applications List are too wide #17220 (#17340) * fix(ui): The tiles in Applications List are too wide Signed-off-by: Rafal Pelczar <[email protected]> * change min width of app tiles Signed-off-by: Rafal Pelczar <[email protected]> --------- Signed-off-by: Rafal Pelczar <[email protected]> * chore(notifications): remove unneeded operations from templates (#17307) * chore(deps): bump library/ubuntu in /test/container (#13409) Bumps library/ubuntu from `9a0bdde` to `67211c1`. --- updated-dependencies: - dependency-name: library/ubuntu dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Michael Firestone <[email protected]> * rm unneeded operations from templates Signed-off-by: Michael Firestone <[email protected]> Signed-off-by: Michael Firestone <[email protected]> * rm more unneeded ops Signed-off-by: Michael Firestone <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Michael Firestone <[email protected]> Signed-off-by: Michael Firestone <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Firestone <[email protected]> * feat: allow webhook settings to be referenced by external secret (#16262) Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * feat: Add app data to sharding cache to allow sharding by apps (#17014) * Adding app list to sharding cache Signed-off-by: Andrew Lee <[email protected]> * Add shard by apps test Signed-off-by: Andrew Lee <[email protected]> * Fix lint Signed-off-by: Andrew Lee <[email protected]> * Add coverage to test Signed-off-by: Andrew Lee <[email protected]> * Fix lint Signed-off-by: Andrew Lee <[email protected]> * Converted cluster/app accesors to private, add apps-in-any-namespace suport in shardingcache init, added read lock to GetAppDistribution Signed-off-by: Andrew Lee <[email protected]> * Fix tests Signed-off-by: Andrew Lee <[email protected]> --------- Signed-off-by: Andrew Lee <[email protected]> * docs: Update USERS.md (#17371) Hi, I added IABAI as using officially ArgoCD Signed-off-by: Andrea Sannuto <[email protected]> * feat: add cli commands to add/delete sourceNamespaces from AppProject (#17337) * Add cli to add/delete sourceNamespaces Signed-off-by: Raghavi Shirur <[email protected]> * update command/comments Signed-off-by: Raghavi Shirur <[email protected]> * update command/comments(1) Signed-off-by: Raghavi Shirur <[email protected]> * update user-guide docs Signed-off-by: Raghavi Shirur <[email protected]> * Retrigger CI pipeline Signed-off-by: Raghavi Shirur <[email protected]> * add check for '*' & rename command to remove-source-namespace Signed-off-by: Raghavi Shirur <[email protected]> * update command/comments(2) Signed-off-by: Raghavi Shirur <[email protected]> * update command/comments(3) Signed-off-by: Raghavi Shirur <[email protected]> * Retrigger CI pipeline Signed-off-by: Raghavi Shirur <[email protected]> --------- Signed-off-by: Raghavi Shirur <[email protected]> * feat: add ability to auto label clusters from k8s clusterinfo (#17289) * feat: add ability to auto label clusters This gives the ability to automatically label cluster secrets on a cluster-by-cluster basis. If `enableClusterInfoLabels` is set on a cluster secret, the controller will (eventually) label the cluster secret with the current k8s version detected by the cluster info. This needs documentation, e2e tests, as well as CLI/UI additions. Signed-off-by: Blake Pettersson <[email protected]> * refactor: use labels instead of secret data This is easier to work with, especially in the context where we need this feature. Signed-off-by: Blake Pettersson <[email protected]> * docs: add description on how to use dynamic labeling Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Blake Pettersson <[email protected]> * chore(ci): free up disk space for goreleaser (#17373) Signed-off-by: Michael Crenshaw <[email protected]> * fix(ui): Dark-mode-enhancements (#17241) * dark-mode-enhancements Signed-off-by: Surajyadav <[email protected]> * monaco Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Suraj yadav <[email protected]> * feat: add cli commands to add/remove sources for multi-source applications (#17310) * Initial commit Signed-off-by: ishitasequeira <[email protected]> * add cli commands to add/remove sources for multi-source app Signed-off-by: ishitasequeira <[email protected]> * add checks Signed-off-by: ishitasequeira <[email protected]> * add docs Signed-off-by: ishitasequeira <[email protected]> * refactor code and update tests Signed-off-by: ishitasequeira <[email protected]> * add removed additional switch case Signed-off-by: ishitasequeira <[email protected]> * fix suggested nits Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]> * feat: enable users to run commands related to Argo Applications in any namespace (#17360) * enable --app-namespace falg for application get command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application diff command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application wait command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application rollback command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application patch command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application edit command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application history command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application sync command Signed-off-by: Mangaal <[email protected]> * enable --app-namespace falg for application delete command Signed-off-by: Mangaal <[email protected]> * cli doc generated Signed-off-by: Mangaal <[email protected]> --------- Signed-off-by: Mangaal <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]> * fix: preserve escape codes in repo url of git webhook payload (#17376) Signed-off-by: Eric Bissonnette <[email protected]> * fix: disable rate limiting sompletely by default (#17355) Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * docs: use service-name instead of service-id (#17389) * use service-name instead of service-id Signed-off-by: DongHo Jung <[email protected]> * trigger CICD Signed-off-by: DongHo Jung <[email protected]> --------- Signed-off-by: DongHo Jung <[email protected]> * feat: Allow Kustomize common labels to not apply to selectors (#17329) * modify crds Signed-off-by: Collin <[email protected]> Signed-off-by: lets-call-n-walk <[email protected]> * cmd opts and test Signed-off-by: Collin <[email protected]> Signed-off-by: lets-call-n-walk <[email protected]> * kustomize build and test Signed-off-by: Collin <[email protected]> Signed-off-by: lets-call-n-walk <[email protected]> * fix option order and add ancestry to users Signed-off-by: lets-call-n-walk <[email protected]> * fix users format Signed-off-by: lets-call-n-walk <[email protected]> * generated files Signed-off-by: lets-call-n-walk <[email protected]> * set flag value Signed-off-by: lets-call-n-walk <[email protected]> * modify crds Signed-off-by: Collin <[email protected]> Signed-off-by: lets-call-n-walk <[email protected]> * chore(deps): bump library/registry in /test/container (#17317) Bumps library/registry from `b209a41` to `f4e1b87`. --- updated-dependencies: - dependency-name: library/registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Collin <[email protected]> Signed-off-by: lets-call-n-walk <[email protected]> * generated files Signed-off-by: lets-call-n-walk <[email protected]> * add docs Signed-off-by: lets-call-n-walk <[email protected]> * fix doc Signed-off-by: lets-call-n-walk <[email protected]> * remove debug prints Signed-off-by: lets-call-n-walk <[email protected]> * fix autogen docs Signed-off-by: lets-call-n-walk <[email protected]> --------- Signed-off-by: Collin <[email protected]> Signed-off-by: lets-call-n-walk <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Collin Walker <[email protected]> Co-authored-by: Collin <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(ui): Highlight failing containers in the UI (#17143) * failing container icon added Signed-off-by: Surajyadav <[email protected]> * lint-fix Signed-off-by: Surajyadav <[email protected]> * .. Signed-off-by: Surajyadav <[email protected]> * tried yarn lint-fix Signed-off-by: Surajyadav <[email protected]> * margin Signed-off-by: Surajyadav <[email protected]> * running Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> * fix(ui): application-summary-help-icon fix (#17385) * Update application-summary.tsx revision-history icon fix Signed-off-by: Suraj yadav <[email protected]> * icons Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Suraj yadav <[email protected]> Signed-off-by: Surajyadav <[email protected]> * chore: add more unit tests around useDiffCache function (#17404) * chore: add more unit tests around useDiffCache function Signed-off-by: Leonardo Luz Almeida <[email protected]> * fix doc Signed-off-by: Leonardo Luz Almeida <[email protected]> --------- Signed-off-by: Leonardo Luz Almeida <[email protected]> * fix(grpcproxy): parse headers contain colon (#13274) (#14294) * fix(grpcproxy): parse headers contain colon Signed-off-by: bogay <[email protected]> * test(apiclient): headers in wrong format Signed-off-by: bogay <[email protected]> --------- Signed-off-by: bogay <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> * docs: Fix some awkward phrasing in `core.md` (#17412) Signed-off-by: Nate Douglas <[email protected]> * docs (aks cluster): update workloadidentity documentation (#17401) Signed-off-by: duncan485 <[email protected]> * docs: remove repetitive words (#17430) Signed-off-by: hishope <[email protected]> * feat(cli): enable --app-namespace flag for argocd app subcommand (#17437) * add --app-namespace flag for set/unset command Signed-off-by: Mangaal <[email protected]> * add --app-namespace flag for add-source/remove-source command Signed-off-by: Mangaal <[email protected]> * fix bug, handle array out of-bound when --source-index=len(source) Signed-off-by: Mangaal <[email protected]> * add documentation Signed-off-by: Mangaal <[email protected]> --------- Signed-off-by: Mangaal <[email protected]> * docs: Clarify for `valueFiles` behaviour with `path` field (#17431) This commit adds clarification by explaining that `valueFiles` must be a relative path to the root of sources, even if the `path` field is set. Signed-off-by: Takahiro Suzuki <[email protected]> Signed-off-by: tkasuz <[email protected]> * docs: Small edits to `docs/user-guide/application-set.md` (#17434) * Update application-set.md Signed-off-by: Nate Douglas <[email protected]> * Make example code consistent with examples elsewhere. Signed-off-by: Nathan Douglas <[email protected]> --------- Signed-off-by: Nate Douglas <[email protected]> Signed-off-by: Nathan Douglas <[email protected]> * fix: add retry condition with kube-apiserver sent GOAWAY (#17422) Signed-off-by: penglongli <[email protected]> * fix(ui): align resource nodegroup (#17427) Signed-off-by: Caio Paiva <[email protected]> * docs: proposal to implement sync timeout and termination settings (#16630) Signed-off-by: Alexander Matyushentsev <[email protected]> * feat: Allow mkdocs to livereload when using docker (#17383) * feat: Allow mkdocs to livereload when using docker Signed-off-by: Carlos Santana <[email protected]> * update the docs Signed-off-by: Carlos Santana <[email protected]> --------- Signed-off-by: Carlos Santana <[email protected]> * chore(deps): bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (#17442) Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.1 to 3.0.3. - [Release notes](https://github.com/go-jose/go-jose/releases) - [Changelog](https://github.com/go-jose/go-jose/blob/v3.0.3/CHANGELOG.md) - [Commits](https://github.com/go-jose/go-jose/compare/v3.0.1...v3.0.3) --- updated-dependencies: - dependency-name: github.com/go-jose/go-jose/v3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Fix Helm Installation Breaking on Mac (#17426) * fix helm installation to work with mac Signed-off-by: lets-call-n-walk <[email protected]> * fix checksums Signed-off-by: lets-call-n-walk <[email protected]> * change install filename and makefile Signed-off-by: lets-call-n-walk <[email protected]> * change name to just helm - fix dockerfile Signed-off-by: lets-call-n-walk <[email protected]> --------- Signed-off-by: lets-call-n-walk <[email protected]> * docs: re-worded updated a link in release-process-and-cadance.md (#17438) Signed-off-by: AlbinB97 <[email protected]> * Fixed `project` parameter docs for Gitlab pull request generator (#17429) Signed-off-by: Nguyen Thai <[email protected]> * chore: update cosign and version (#17441) * chore: update cosign and version Signed-off-by: Justin Marquis <[email protected]> * fix typo Signed-off-by: Justin Marquis <[email protected]> --------- Signed-off-by: Justin Marquis <[email protected]> * chore: update slsa3 generate (#17451) Signed-off-by: Justin Marquis <[email protected]> * docs: dex google oidc: add note on dex connector type (#17453) Signed-off-by: Aiman Ismail <[email protected]> * docs: Update site.md (#17454) erros -> errors Signed-off-by: Ikko Eltociear Ashimine <[email protected]> * add Oncourse Home (#17457) * chore(deps): bump library/busybox in /test/e2e/multiarch-container (#17445) Bumps library/busybox from `3fbc632` to `650fd57`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/node from 21.6.2 to 21.7.0 in /ui-test (#17444) Bumps library/node from 21.6.2 to 21.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * make CGO_ENABLED configurable (#17462) Signed-off-by: Mark McCormick <[email protected]> * chore(deps): bump library/ubuntu in /test/container (#17414) Bumps library/ubuntu from `f9d633f` to `77906da`. --- updated-dependencies: - dependency-name: library/ubuntu dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: remove repetitive words (#17464) Signed-off-by: avoidalone <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * feat: add option `manual` to the `--sync-policy` flag of the `app create` command (#17459) * feat: add sync policy option 'manual' for app create command Signed-off-by: Anirudh Sudhir <[email protected]> * chore: Update tests to reflect sync policy option changes Signed-off-by: Anirudh Sudhir <[email protected]> --------- Signed-off-by: Anirudh Sudhir <[email protected]> * [Bot] docs: Update Snyk reports (#17458) Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]> * docs: fix kustomize example resources url (#17468) Signed-off-by: Jonas Bakken <[email protected]> * chore(deps): bump library/node from 21.6.2 to 21.7.1 in /test/container (#17475) Bumps library/node from 21.6.2 to 21.7.1. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/golang in /test/container (#17415) Bumps library/golang from 1.21.3 to 1.22.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(notifications): Helm.GetParameterValueByName should take helm.parametes first (#17472) * fix: Helm.GetParameterValueByName should take helm.parametes first Signed-off-by: pashakostohrys <[email protected]> * fix linters Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> * fix: registry argument to be only the host instead full URL (#17381) Signed-off-by: Pablo Aguilar <[email protected]> * chore: Fix containerized toolchain (#17480) Signed-off-by: jannfis <[email protected]> * chore(deps): bump docker/build-push-action from 5.1.0 to 5.2.0 (#17463) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/4a13e500e55cf31b7a5d59a38ab2040ab0f42f56...af5a7ed5ba88268d5278f7203fb52cd833f66d6e) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * docs: remove `configManagementPlugins` from argocd-cm.yaml (#17486) That field is no longer supported. Signed-off-by: Michael Crenshaw <[email protected]> * chore: Support running and testing locally using podman instead of docker (#17481) * chore: Support rootless podman for run/test Signed-off-by: jannfis <[email protected]> * Note DOCKER env in docs Signed-off-by: jannfis <[email protected]> --------- Signed-off-by: jannfis <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]> * fix(appset): keep reconciling even when params error occurred (#17062) * fix(appset): keep reconcile even when params error occurred Signed-off-by: Or Koren <[email protected]> * requeue on generator rendering error Signed-off-by: Or Koren <[email protected]> * test ignoring partial rendering errors Signed-off-by: Or Koren <[email protected]> * e2e test create app with param error Signed-off-by: Or Koren <[email protected]> --------- Signed-off-by: Or Koren <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> * docs(EKS): Fix ArgoCD management role AssumeRole policy for IRSA (#17455) Signed-off-by: Xavier Krantz <[email protected]> * chore(deps): bump library/node from 21.7.0 to 21.7.1 in /ui-test (#17498) Bumps library/node from 21.7.0 to 21.7.1. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/golang in /test/container (#17495) Bumps library/golang from `34ce21a` to `0b55ab8`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/redis in /test/container (#17496) Bumps library/redis from `e647cfe` to `7dd7070`. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * chore(deps): bump library/node in /test/container (#17494) Bumps library/node from `f358dfc` to `b9ccc4a`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <[email protected]> * Make evergreen (#17507) This example uses an old revision `v1.0.1` instead it should just use stable. Signed-off-by: Dan Garfield <[email protected]> * docs: added all available fields for applicationset.yaml #16095 (#16104) * adding all available filds for generators Signed-off-by: Harshvir Potpose <[email protected]> * add remaining fields in applicationset.yml Signed-off-by: Harshvir Potpose <[email protected]> * Update docs/operator-manual/applicationset.yaml Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> * Update docs/operator-manual/applicationset.yaml Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> * Update docs/operator-manual/applicationset.yaml Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> * Update docs/operator-manual/applicationset.yaml Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> * fix Signed-off-by: Harshvir Potpose <[email protected]> --------- Signed-off-by: Harshvir Potpose <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> * docs: Add note in installation step 1 with argocd cli (#8030) * Add note in installation stesps Added notes in installation step 1: kubectl config set-context --current --namespace=argocd * Updated doc * Update docs/getting_started.md Signed-off-by: Dan Garfield <[email protected]> --------- Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * Add documentation for google transitive groups (#9487) Signed-off-by: Trung <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> * fix: elements should be optional (#17424) A bug was reported, where an applicationset with an empty elements array, when created with `argocd appset create <filename>.yaml` gets a `...list.elements: Required value` error. My hypothesis is that when calling the K8s API, golang JSON marshalling mangles the empty `elements` array to `nil`, rather than creating an empty array when submitting the `POST`. Still need to figure out why the same setup seemingly works fine when the same appset is in an app-of-apps. Signed-off-by: Blake Pettersson <[email protected]> * Merge pull request from GHSA-jwv5-8mqv-g387 * fix: Validate external URLs for applicatins Signed-off-by: Ry0taK <[email protected]> * fix(ui): remove invalid external-link Signed-off-by: Alexandre Gaudreault <[email protected]> * linting Signed-off-by: Alexandre Gaudreault <[email protected]> --------- Signed-off-by: Ry0taK <[email protected]> Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]> * Merge pull request from GHSA-g623-jcgg-mhmm Signed-off-by: Michael Crenshaw <[email protected]> * feat: Add support to enable FullTimeStamp in logging (#15127) * Add support to enable FullTimeStamp in logging Signed-off-by: skalinov <[email protected]> * fix: Fix go linter file exist issue Signed-off-by: skalinov <[email protected]> * fix: Remove --skip-pkg-cache Signed-off-by: skalinov <[email protected]> * Update util/log/logrus_test.go Use custom set env for prevent linter to be failed Signed-off-by: pasha-codefresh <[email protected]> * Update common/common.go Signed-off-by: Dan Garfield <[email protected]> * Update util/log/logrus_test.go Signed-off-by: pasha-codefresh <[email protected]> * Update util/log/logrus_test.go remove os import Signed-off-by: pasha-codefresh <[email protected]> * Update util/log/logrus_test.go sort dependencies Signed-off-by: pasha-codefresh <[email protected]> * fix formatting Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pasha-codefresh <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Co-authored-by: skalinov <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * docs: add attestation of SBOM to release assets in signed-release-assets.md (#17520) Closes https://github.com/argoproj/argo-cd/issues/17200. Signed-off-by: Andreas Hunkeler <[email protected]> * fix: Argo CD unnecessary enforce sequential helm manifest generation for one chart (#17518) * fix: Argo CD unnecessary enforce sequential helm manifest generation for one chart Signed-off-by: Alexander Matyushentsev <[email protected]> * Update docs/operator-manual/high_availability.md Signed-off-by: Dan Garfield <[email protected]> --------- Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * chore(deps): bump actions/checkout (#17493) Bumps [actions/checkout](https://github.com/actions/checkout) from 3df4ab11eba7bda6032a0b82a6bb43b11571feac to 8410ad0602e1e429cee44a835ae9f77f654a6694. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/3df4ab11eba7bda6032a0b82a6bb43b11571feac...8410ad0602e1e429cee44a835ae9f77f654a6694) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Add error messages to return statements in BlockingDial function (#17521) * Add error messages to return statements in BlockingDial function Signed-off-by: danqixu <[email protected]> * amend error wrapping from %s to %w Signed-off-by: danqixu <[email protected]> --------- Signed-off-by: danqixu <[email protected]> * chore(deps): upgrade helm to 3.14.3 (#17531) * chore(deps): upgrade helm to 3.14.3 Signed-off-by: David Bunn <[email protected]> * chore(deps): upgrade helm to 3.14.3 Signed-off-by: David Bunn <[email protected]> --------- Signed-off-by: David Bunn <[email protected]> * chore(deps): bump docker/build-push-action from 5.2.0 to 5.3.0 (#17537) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.2.0 to 5.3.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/af5a7ed5ba88268d5278f7203fb52cd833f66d6e...2cdde995de11925a030ce8070c3d77a52ffcf1c0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(ui): add confirmation box in resource summary delete action (#17485) Signed-off-by: ashutosh16 <[email protected]> * docs: Update the status of the feature, app in any namespace, from beta to stable (#17529) * Update the status of the feature, app in any namespace, from beta to stable Signed-off-by: Mangaal <[email protected]> * adding warning and removing **Current feature state** Signed-off-by: Mangaal <[email protected]> --------- Signed-off-by: Mangaal <[email protected]> * Merge pull request from GHSA-2vgg-9h6w-m454 * feat: pick random user and exclude admin user and current user from deletion candidates Signed-off-by: pashakostohrys <[email protected]> * feat: increase default max cache size Signed-off-by: pashakostohrys <[email protected]> * add nil protection Signed-off-by: pashakostohrys <[email protected]> * Update util/session/sessionmanager.go Signed-off-by: Dan Garfield <[email protected]> Signed-off-by: Dan Garfield <[email protected]> * chore: fix linter issues Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]> Signed-off-by: Dan Garfield <[email protected]> Co-authored-by: Dan Garfield <[email protected]> * Merge pull request from GHSA-6v85-wr92-q4p7 * fix: Fix concurrency issue in session manager Signed-off-by: jannfis <[email protected]> * Add note that modification to the map must be done in a thread safe manner * chore: fix linter issues Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: jannfis <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Co-authored-by: Dan Garfield <[email protected]> Co-authored-by: pashakostohrys <[email protected]> * chore(deps-dev): bump postcss from 8.4.35 to 8.4.36 in /ui (#17555) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.35 to 8.4.36. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.35...8.4.36) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump library/registry in /test/container (#17554) Bumps library/registry from `f4e1b87` to `fb9c9ae`. --- updated-dependencies: - dependency-name: library/registry dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: mention that the argocd diff command does not include secrets (#15950) * doc(cli): update argocd_app_diff Adding the fact that secrets are ignored by the diff (not really stated in the doc so far) Signed-off-by: ario0 <[email protected]> * doc: remove whitespace Signed-off-by: ario0 <[email protected]> --------- Signed-off-by: ario0 <[email protected]> Signed-off-by: Alexis Renard <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]> * feat: add cli commands to create/set/unset/edit sources for multi-source application (#17425) * "feat:add cli commands to create/set/unset/edit sources for multi-source app" Signed-off-by: ishitasequeira <[email protected]> * fixed the ci failure Signed-off-by: ishitasequeira <[email protected]> * update commands Signed-off-by: ishitasequeira <[email protected]> * error out if source-index not specified for multi-source applications Signed-off-by: ishitasequeira <[email protected]> * fixed the ci failure Signed-off-by: ishitasequeira <[email protected]> * fix tests Signed-off-by: ishitasequeira <[email protected]> * set 0 as default source index for app create Signed-off-by: ishitasequeira <[email protected]> * add index to ParameterOverrides function Signed-off-by: ishitasequeira <[email protected]> * do not allow overrides for applications with multiple sources Signed-off-by: ishitasequeira <[email protected]> * update tests Signed-off-by: ishitasequeira <[email protected]> * remove create with override example Signed-off-by: ishitasequeira <[email protected]> * address comments Signed-off-by: ishitasequeira <[email protected]> * update tests Signed-off-by: ishitasequeira <[email protected]> * update examples in docs Signed-off-by: ishitasequeira <[email protected]> * update logs Signed-off-by: ishitasequeira <[email protected]> * Add test and update docs Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]> * feat(UI): Added link for docs to add clusters (#17395) * cluster-add-link Signed-off-by: Surajyadav <[email protected]> * docs Signed-off-by: Surajyadav <[email protected]> * docs-panel Signed-off-by: Surajyadav <[email protected]> * added Signed-off-by: Surajyadav <[email protected]> * fixed Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> * chore(deps-dev): bump postcss from 8.4.36 to 8.4.37 in /ui (#17573) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.36 to 8.4.37. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.36...8.4.37) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: Fix linter issue with session manager (#17597) Signed-off-by: jannfis <[email protected]> * chore(deps): bump slsa-framework/slsa-github-generator (#17593) Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](https://github.com/slsa-framework/slsa-github-generator/compare/v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump webpack-dev-middleware from 5.3.1 to 5.3.4 in /ui (#17598) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.1 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-dev-middleware/compare/v5.3.1...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.37 to 8.4.38 in /ui (#17582) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.37 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.c…

ishitasequeira marked this pull request as ready for review March 7, 2024 02:59

ishitasequeira requested review from a team as code owners March 7, 2024 02:59

ishitasequeira changed the title ~~feat: add cli commands to create/set/unset/edit sources for multi-sou…rce app~~ feat: add cli commands to create/set/unset/edit sources for multi-source application Mar 7, 2024

ishitasequeira added the multi-source-apps Bugs or enhancements related to multi-source Applications. label Mar 8, 2024

jannfis reviewed Mar 8, 2024

View reviewed changes

ishitasequeira requested a review from a team as a code owner March 8, 2024 19:20

jannfis reviewed Mar 12, 2024

View reviewed changes

ishitasequeira added the component:cli Affects the Argo CD CLI label Mar 12, 2024

anandf reviewed Mar 15, 2024

View reviewed changes

cmd/util/app_test.go Show resolved Hide resolved

ishitasequeira added 10 commits March 15, 2024 11:45

"feat:add cli commands to create/set/unset/edit sources for multi-sou…

609f2b9

…rce app" Signed-off-by: ishitasequeira <[email protected]>

fixed the ci failure

5e41659

Signed-off-by: ishitasequeira <[email protected]>

update commands

74f2247

Signed-off-by: ishitasequeira <[email protected]>

error out if source-index not specified for multi-source applications

22ffda5

Signed-off-by: ishitasequeira <[email protected]>

fixed the ci failure

b0a0f7f

Signed-off-by: ishitasequeira <[email protected]>

fix tests

1ee6847

Signed-off-by: ishitasequeira <[email protected]>

set 0 as default source index for app create

38d90cb

Signed-off-by: ishitasequeira <[email protected]>

add index to ParameterOverrides function

78a718e

Signed-off-by: ishitasequeira <[email protected]>

do not allow overrides for applications with multiple sources

75941d1

Signed-off-by: ishitasequeira <[email protected]>

update tests

17b7d5b

Signed-off-by: ishitasequeira <[email protected]>

ishitasequeira added 6 commits March 15, 2024 11:45

remove create with override example

1d2cc37

Signed-off-by: ishitasequeira <[email protected]>

address comments

d660bde

Signed-off-by: ishitasequeira <[email protected]>

update tests

a0be16e

Signed-off-by: ishitasequeira <[email protected]>

update examples in docs

ed5263c

Signed-off-by: ishitasequeira <[email protected]>

update logs

2981def

Signed-off-by: ishitasequeira <[email protected]>

Add test and update docs

3520132

Signed-off-by: ishitasequeira <[email protected]>

anandf approved these changes Mar 15, 2024

View reviewed changes

jannfis approved these changes Mar 18, 2024

View reviewed changes

jannfis merged commit ed0218f into argoproj:master Mar 18, 2024
27 checks passed

This was referenced Mar 29, 2024

Parameter overrides not honored in multi-source helm/git setup #14296

Closed

feat(cli): add support for multiple sources to app diff|manifests command with revisions flag #17650

Merged

agaudreault mentioned this pull request Apr 4, 2024

Add optional name reference to Source object #17731

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add cli commands to create/set/unset/edit sources for multi-source application #17425

feat: add cli commands to create/set/unset/edit sources for multi-source application #17425

ishitasequeira commented Mar 6, 2024 •

edited

Loading

jannfis left a comment •

edited

Loading

ishitasequeira commented Mar 8, 2024 •

edited

Loading

codecov bot commented Mar 8, 2024 •

edited

Loading

ishitasequeira commented Mar 11, 2024

jannfis commented Mar 11, 2024 •

edited

Loading

ishitasequeira commented Mar 11, 2024

jannfis commented Mar 11, 2024

ishitasequeira commented Mar 11, 2024

jannfis commented Mar 11, 2024

ishitasequeira commented Mar 12, 2024

jannfis left a comment

jannfis Mar 12, 2024

jannfis Mar 12, 2024

ishitasequeira Mar 12, 2024 •

edited

Loading

jannfis Mar 12, 2024

jannfis Mar 12, 2024

jannfis Mar 12, 2024

jannfis Mar 12, 2024

jannfis Mar 12, 2024

ishitasequeira Mar 12, 2024 •

edited

Loading

ishitasequeira commented Mar 12, 2024

anandf left a comment

jannfis left a comment

		# Create a MultiSource app
		argocd app create guestbook --file <path-to-yaml-file>

feat: add cli commands to create/set/unset/edit sources for multi-source application #17425

feat: add cli commands to create/set/unset/edit sources for multi-source application #17425

Conversation

ishitasequeira commented Mar 6, 2024 • edited Loading

jannfis left a comment • edited Loading

Choose a reason for hiding this comment

ishitasequeira commented Mar 8, 2024 • edited Loading

codecov bot commented Mar 8, 2024 • edited Loading

Codecov Report

ishitasequeira commented Mar 11, 2024

jannfis commented Mar 11, 2024 • edited Loading

ishitasequeira commented Mar 11, 2024

jannfis commented Mar 11, 2024

ishitasequeira commented Mar 11, 2024

jannfis commented Mar 11, 2024

ishitasequeira commented Mar 12, 2024

jannfis left a comment

Choose a reason for hiding this comment

jannfis Mar 12, 2024

Choose a reason for hiding this comment

jannfis Mar 12, 2024

Choose a reason for hiding this comment

ishitasequeira Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

jannfis Mar 12, 2024

Choose a reason for hiding this comment

jannfis Mar 12, 2024

Choose a reason for hiding this comment

jannfis Mar 12, 2024

Choose a reason for hiding this comment

jannfis Mar 12, 2024

Choose a reason for hiding this comment

jannfis Mar 12, 2024

Choose a reason for hiding this comment

ishitasequeira Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

ishitasequeira commented Mar 12, 2024

anandf left a comment

Choose a reason for hiding this comment

jannfis left a comment

Choose a reason for hiding this comment

ishitasequeira commented Mar 6, 2024 •

edited

Loading

jannfis left a comment •

edited

Loading

ishitasequeira commented Mar 8, 2024 •

edited

Loading

codecov bot commented Mar 8, 2024 •

edited

Loading

jannfis commented Mar 11, 2024 •

edited

Loading

ishitasequeira Mar 12, 2024 •

edited

Loading

ishitasequeira Mar 12, 2024 •

edited

Loading